Implement dialog to add/edit a single channel in database
Implement a dialog to add/edit a single channel and a dialog to edit parameter that is call from the channel dialog
- Currently using QLineEdit for display/editing ValueColor. Later, a custom widget will be developed to have better display and easier editing.
- Parameter 'Default' is only display for the channel that has no record in DB but won't be allow to select or save or call para dialog to edit.
For testing add/edit single channel, run sohstationviewer/view/db_config/add_edit_single_channel_dialog.py and change the example lines in main
For testing edit single param, run sohstationviewer/view/db_config/add_edit_single_channel_dialog.py and change the example lines in main; or press on button 'EDIT PARAMETER' of the above dialog.
Merge request reports
Activity
assigned to @ldam
requested review from @kienle
- Resolved by Kien Le
Change the name of the MR to
Implement dialog to add/edit a single channel in database
. We want to name MRs based on the feature they implement, not the actual code being implemented.
added 5 commits
-
045e0df7...b176fed0 - 4 commits from branch
master
- a0dd4112 - Merge branch 'master' into i69-add-edit-single-channel-dialog
-
045e0df7...b176fed0 - 4 commits from branch
- Resolved by Kien Le
- Resolved by Kien Le
- Resolved by Kien Le
- Resolved by Kien Le
- Resolved by Kien Le
I think it would be a better idea to split the editing of channels and the editing of the parameters into different dialogs. It would still be a good idea to show how the channel will be plotted, but I don't think letting the user edit the parameter for multiple channels in the edit dialog for one channel is good.
- Resolved by Kien Le
- Resolved by Kien Le
When changing parameter, if no is chosen, the parameter changes to the default parameter instead of the previous parameter. I think this has to do with the lambda in
connect_signals()
. Also, the plotting info does not change back to the one of the default parameter.
added 9 commits
-
a0dd4112...727a136c - 2 commits from branch
master
- e5f58a83 - change names of function, variable to be more descriptive' spelling, change...
- aa6729dd - Merge branch 'master' into i69-add-edit-single-channel-dialog
- dda80caa - add modify_db_path to test dialog separately from main
- 4d87d055 - change back conversion widget to QLineEdit because conversion can go down to 1.0e-06
- cf6162f3 - change back conversion widget to QLineEdit because conversion can go down to...
- 0e265d25 - move function to extract info from add_edit_single_channel_helper.py to extract_data.py
- 6501d4dd - move para info to a separate dialog, improve on_param_cbobox_changed, add self.param variable
Toggle commit list-
a0dd4112...727a136c - 2 commits from branch
- Resolved by Lan Dam
- Resolved by Lan Dam