Skip to content
Snippets Groups Projects

Implement dialog to add/edit a single channel in database

Merged Lan Dam requested to merge i69-add-edit-single-channel-dialog into master
All threads resolved!

#69 (closed)

Implement a dialog to add/edit a single channel and a dialog to edit parameter that is call from the channel dialog

  • Currently using QLineEdit for display/editing ValueColor. Later, a custom widget will be developed to have better display and easier editing.
  • Parameter 'Default' is only display for the channel that has no record in DB but won't be allow to select or save or call para dialog to edit.

For testing add/edit single channel, run sohstationviewer/view/db_config/add_edit_single_channel_dialog.py and change the example lines in main

For testing edit single param, run sohstationviewer/view/db_config/add_edit_single_channel_dialog.py and change the example lines in main; or press on button 'EDIT PARAMETER' of the above dialog.

Edited by Lan Dam

Merge request reports

Pipeline #3278 passed

Pipeline passed for a7c46db2 on i69-add-edit-single-channel-dialog

Approval is optional

Merged by Lan DamLan Dam 1 year ago (Nov 21, 2023 5:59pm UTC)

Merge details

  • Changes merged into master with 6dde416e (commits were squashed).
  • Deleted the source branch.

Pipeline #3279 passed

Pipeline passed for 6dde416e on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Kien Le
  • Kien Le
  • Kien Le
  • Kien Le
  • Developer

    I think it would be a better idea to split the editing of channels and the editing of the parameters into different dialogs. It would still be a good idea to show how the channel will be plotted, but I don't think letting the user edit the parameter for multiple channels in the edit dialog for one channel is good.

  • Kien Le
    • Developer
      Resolved by Kien Le

      When changing parameter, if no is chosen, the parameter changes to the default parameter instead of the previous parameter. I think this has to do with the lambda in connect_signals(). Also, the plotting info does not change back to the one of the default parameter.

  • Lan Dam changed the description

    changed the description

  • Lan Dam added 9 commits

    added 9 commits

    • a0dd4112...727a136c - 2 commits from branch master
    • e5f58a83 - change names of function, variable to be more descriptive' spelling, change...
    • aa6729dd - Merge branch 'master' into i69-add-edit-single-channel-dialog
    • dda80caa - add modify_db_path to test dialog separately from main
    • 4d87d055 - change back conversion widget to QLineEdit because conversion can go down to 1.0e-06
    • cf6162f3 - change back conversion widget to QLineEdit because conversion can go down to...
    • 0e265d25 - move function to extract info from add_edit_single_channel_helper.py to extract_data.py
    • 6501d4dd - move para info to a separate dialog, improve on_param_cbobox_changed, add self.param variable

    Compare with previous version

  • Kien Le
  • Kien Le
  • Developer

    I only see some minor problems on a re-review. Once you fixed all the problems and checked to make sure that you can edit the parameter for a channel, you can merge this MR. I'll approve in advance.

  • Kien Le approved this merge request

    approved this merge request

  • Lan Dam added 9 commits

    added 9 commits

    Compare with previous version

  • Lan Dam resolved all threads

    resolved all threads

  • merged

  • Lan Dam mentioned in commit 6dde416e

    mentioned in commit 6dde416e

  • Please register or sign in to reply
    Loading