modify function and variable names to be more descriptive

sohstationviewer/view/select_channels_to_show_dialog.py

@@ -19,11 +19,16 @@ class SelectChanelsToShowDialog(QDialog):
         super(SelectChanelsToShowDialog, self).__init__()
         self.parent = parent
 
-        self.channel_list_widget1 = self.create_chan_list_widget(
+        # reorderablable_chan_list_widget: list widget where channels can be
+        # reordered by dragging and dropping, used to display SOH and waveform
+        # channels
+        self.reorderable_chan_list_widget = self.create_chan_list_widget(
             self.parent.plotting_data1, self.parent.pref_order, True
         )
 
-        self.channel_list_widget2 = self.create_chan_list_widget(
+        # unreorderable_chan_list_widget: list widget where channels can NOT be
+        # reordered, used to display mass position channels
+        self.unreorderable_chan_list_widget = self.create_chan_list_widget(
             self.parent.plotting_data2, [], False
         )
 
@@ -86,11 +91,11 @@ class SelectChanelsToShowDialog(QDialog):
             "* Check to show/ uncheck to hide a channel.\n\n"
             "* Drop and drag channels in the first list to reorder.")
         main_layout.addWidget(label)
-        main_layout.addWidget(self.channel_list_widget1)
+        main_layout.addWidget(self.reorderable_chan_list_widget)
 
         label = QLabel("* Mass Position channels won't be reorderable.")
         main_layout.addWidget(label)
-        main_layout.addWidget(self.channel_list_widget2)
+        main_layout.addWidget(self.unreorderable_chan_list_widget)
 
         button_layout = QtWidgets.QHBoxLayout()
         main_layout.addLayout(button_layout)
@@ -132,10 +137,10 @@ class SelectChanelsToShowDialog(QDialog):
         """
 
         new_pref_order = (
-            self.channel_list_widget_to_plotting_data(
-                self.channel_list_widget1, self.parent.plotting_data1))
-        self.channel_list_widget_to_plotting_data(
-            self.channel_list_widget2, self.parent.plotting_data2)
+            self.apply_selection_to_plotting_data_channel_visible(
+                self.reorderable_chan_list_widget, self.parent.plotting_data1))
+        self.apply_selection_to_plotting_data_channel_visible(
+            self.unreorderable_chan_list_widget, self.parent.plotting_data2)
 
         self.parent.clear()
         self.parent.plot_channels(