Skip to content
Snippets Groups Projects

Feature for users to hide/show and reorder channels

Merged Lan Dam requested to merge i188_hide_show_channels_from_plotted_figure into develop

Closes #188 (closed)

Edited by Lan Dam

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Kien Le
  • Kien Le
    • Developer
      Resolved by Kien Le

      It might be a good idea to enable the context menu anywhere in the SOH plot window. It would be more convenient for user, and also solve the problem where the user can't do anything if they hide all SOH channels.

  • Kien Le
  • Kien Le
  • Kien Le
  • Kien Le
  • Kien Le
  • Lan Dam added 7 commits

    added 7 commits

    • 74066a92 - simplify condition to check show key
    • 8c772fa4 - return super's events to finish them
    • 847138c2 - docstring
    • 8f2c1223 - use number_channel_found to decide opening contextMenu or not
    • 7b172043 - place QLabel on its own line
    • ef70f943 - change key 'show' to 'visible'
    • d0322059 - rename method channel_list_widget_to_plotting_data() to...

    Compare with previous version

  • Author Maintainer

    @kienle I have addressed all of your review except the last one. We may need to talk about that.

  • Lan Dam added 1 commit

    added 1 commit

    • 7bdccc39 - modify function and variable names to be more descriptive

    Compare with previous version

  • 95
    96 label = QLabel("* Mass Position channels won't be reorderable.")
    97 main_layout.addWidget(label)
    98 main_layout.addWidget(self.unreorderable_chan_list_widget)
    99
    100 button_layout = QtWidgets.QHBoxLayout()
    101 main_layout.addLayout(button_layout)
    102 button_layout.addWidget(self.cancel_btn)
    103 button_layout.addWidget(self.apply_btn)
    104
    105 def connect_signals(self) -> None:
    106 self.cancel_btn.clicked.connect(self.close)
    107 self.apply_btn.clicked.connect(self.apply)
    108
    109 @staticmethod
    110 def apply_selection_to_plotting_data_channel_visible(
  • Lan Dam changed target branch from master to develop

    changed target branch from master to develop

  • Kien Le approved this merge request

    approved this merge request

  • Lan Dam added 1 commit

    added 1 commit

    Compare with previous version

  • Lan Dam added 29 commits

    added 29 commits

    • 58c71633...1a3606eb - 28 commits from branch develop
    • b3085937 - Merge branch 'develop' into i188_hide_show_channels_from_plotted_figure

    Compare with previous version

  • Lan Dam changed the description

    changed the description

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading