Skip to content
Snippets Groups Projects

Fix to issue 34: Allow user to copy datalogger type, gain and sensor type to other stations

Merged Destiny Kuehn requested to merge issue-34-copy-dltype-gain-stype-to-other-stations into master

The StationWidget now has two more buttons "Copy Type & Gain To More Stations" under Datalogger and "Copy Type To More Stations" under Sensor. Clicking either one will bring up a child dialog window. "Copy Type & Gain To More Stations" has two checkboxes for type and gain, with a label indicating the value that will be copied to one/both fields. "Copy Type To More Stations" has a label indicating the value that will be copied to selected stations' sensor types. The dialog has a table widget of all stations in inventory, and similar to the inventory tree, the user can single click on stations, hold ctrl to select multiple individual stations, or hold shift to select a range of stations.

Edited by Destiny Kuehn

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Destiny Kuehn requested review from @maeva

    requested review from @maeva

  • assigned to @dkuehn

  • Destiny Kuehn changed the description

    changed the description

  • Destiny Kuehn added 2 commits

    added 2 commits

    • 6cadd662 - Fix for issue 35: Display full Start/End time to the microsecond
    • 628f5f65 - add elided start/end times

    Compare with previous version

  • I like the solution but so far it doesn't seem to be working.

    In my use case, I have two stations. I specify the Datalogger gain and type for station 1. Then I select Copy Type & Gain to More Stations, select my station 2 (to which I want the same gain and type to be applied) and select OK. I then look at the Datalogger gain and type for station 2 by selecting station 2. Its datalogger gain and type is still set to Na.

    You may want to take another look at your update_inventory method. That might be where the issue is.

    I also think that the layout and options in the pop up windows when selecting the Copy Type... buttons should be updated.

    Here are some suggestions:

    • In the pop up window that opens after selecting Copy Type & Gain to More Stations under datalogger, we should remove the Copy Sensor Type checkbox. The user shouldn't have that option here since they are working on specifying parameters for the datalogger. I would also add two text labels above the checkboxes to remind the user of the datalogger gain and type they selected for their first station. It would be fairly similar to the text label that is added in the ChannelSelectDialog.ui to remind the user which station they are about to split.
    • In the pop up window that opens after selecting Copy Type to More Stations under sensor, I would remove all checkboxes since there should only be one option here (i.e., copy sensor type). If the user selected the button that opened that pop up window in the first place, we can safely assume that that is what they want to do. I would also add a text label above the table to remind the user of the sensor type they selected for their first station.

    Let me know if you have any questions regarding these suggestions.

  • Destiny Kuehn added 3 commits

    added 3 commits

    • 75b5a376 - remove break on update_inventory
    • 1f025b3e - remove sensor cb from copy type/gain and vice versa
    • a835ce49 - make sensor type a label and add value to be copied to text in popup

    Compare with previous version

  • Author Developer

    @maeva The new commits should address the above suggestions.

  • Destiny Kuehn changed the description

    changed the description

  • Maeva Pourpoint added 20 commits

    added 20 commits

    • a835ce49...81d0dac8 - 8 commits from branch master
    • 81d0dac8...97c6d13b - 2 earlier commits
    • d84663a4 - fix sorting bug
    • 0f0c0155 - fix break in loop
    • 0ecec9ac - add elided start/end times
    • 35c66815 - remove break on update_inventory
    • 7c3a30dd - remove sensor cb from copy type/gain and vice versa
    • 4e3a0e69 - make sensor type a label and add value to be copied to text in popup
    • a681a793 - Rename widgets in StationSelectDialog.ui and resize Station Select window
    • 4bd3991e - Loop over columns in Station Select Window
    • 4a4b2d7c - Set constraints on header resizing for Station Select and Channel Select windows
    • 1c0d8466 - Add correct indentation + Rename variables in main module

    Compare with previous version

  • I just reviewed the changes you made based on my previous suggestions. That looks good.

    I just cleaned up the code a little mostly for consistency.

  • Maeva Pourpoint mentioned in commit 2f3433d0

    mentioned in commit 2f3433d0

  • mentioned in issue #34 (closed)

Please register or sign in to reply
Loading