Skip to content
Snippets Groups Projects

Show time label on top of ruler

Merged Kien Le requested to merge feature-#71-time_label_on_top_of_ruler into master

Closes #71 (closed)

Edited by Kien Le

Merge request reports

Pipeline #2497 passed

Pipeline passed for 6773daff on feature-#71-time_label_on_top_of_ruler

Merged by Kien LeKien Le 1 year ago (Apr 24, 2023 8:56pm UTC)

Loading

Pipeline #2499 passed

Pipeline passed for 4e7727fa on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Lan Dam
  • Lan Dam
  • Maintainer

    It works pretty well. Improve behavior as I recommended and give info about new_min_x. Thank you.

    Edited by Lan Dam
  • Kien Le added 18 commits

    added 18 commits

    Compare with previous version

  • Kien Le added 1 commit

    added 1 commit

    • caba3dea - Make ruler text the same color as ruler

    Compare with previous version

  • assigned to @kienle

  • Kien Le removed review request for @ldam

    removed review request for @ldam

  • Kien Le requested review from @ldam

    requested review from @ldam

  • Lan Dam resolved all threads

    resolved all threads

    • Maintainer

      @kienle All my last reviews were solved. However there are some problem when waveform dialog opens. If I move the ruler on main window, all ruler's texts on waveform dialog won't disappear. As the result there are a lot of ruler's texts left. Same with if I move ruler on waveform dialog, all ruler's texts on main window won't disappear.

    • Author Developer

      This should be fixed now.

    • Please register or sign in to reply
  • Kien Le added 1 commit

    added 1 commit

    • 07881151 - Fix ruler text removal not being synced

    Compare with previous version

  • Kien Le removed review request for @ldam

    removed review request for @ldam

  • Kien Le requested review from @ldam

    requested review from @ldam

  • Maintainer

    @kienle Only one problem left now. In case you have main window and waveform dialog both open and have the ruler on. Now when you click ESC, all the rulers disappear but the ruler's text of the inactivate window still remain. It's supposed that all rulers and rulers' texts disappeared on ESC.

  • Kien Le added 1 commit

    added 1 commit

    • c7881399 - Remove ruler texts in all plot on ESC pressed

    Compare with previous version

  • Lan Dam approved this merge request

    approved this merge request

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading