Skip to content
Snippets Groups Projects

Fix lines appearing on waveform plots after zoom

Closed Kien Le requested to merge bug-#33-extra_lines_appear_in_waveform_plot_on_zoom_in into master
1 unresolved thread

Merge request reports

Pipeline #2310 failed

Pipeline failed for f032f265 on bug-#33-extra_lines_appear_in_waveform_plot_on_zoom_in

Closed by Kien LeKien Le 2 years ago (Mar 22, 2023 8:24pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
268 270 DataTypeModel.__init__.mass_pos_data[key][chan_id]
269 271 :param chan_id: str - name of channel
270 272 """
273 times: np.ndarray = c_data['times']
274 data: np.ndarray = c_data['data']
275 sorted_index = times.argsort()
276 times = times[sorted_index]
277 data = data[sorted_index]
278 c_data['times'] = times
279 c_data['data'] = data
  • Comment on lines +273 to +279
    Maintainer

    This might resolve the extra line but it clear out overlapped data which user need to see. I think the way we treat data by merging it isn't a good way. If we can plot each trace separately it would be better not just with wave form but with soh as well. I don't know how it affect the plotting performance. If you have time, you can try it or I will work on it when I finish with my MRs.

  • Please register or sign in to reply
  • Author Developer

    The useful functionalities implemented in this merge request is included in !88 (merged), so this merge request can be closed.

  • closed

  • Kien Le removed review request for @ldam

    removed review request for @ldam

  • Please register or sign in to reply
    Loading