Fix bug on RT130 that wrongly giving warning box when some DS is selected with RAW/TPS checked

closes #284 (closed)

Move detect_data_type before get_requested_wf_chans because the later requires data_type.

assigned to @ldam

requested review from @kienle

changed title from move detect_data_type before get_reauested_wf_chans because the later requires data_type to move detect_data_type before get_requested_wf_chans because the later requires data_type

changed milestone to %2024.3.1.0

Rename this merge request to make clear what problem it solves.

changed title from move detect_data_type before get_requested_wf_chans because the later requires data_type to Fix bug on RT130 that wrongly giving warning box when some DS is selected with RAW/TPS checked

changed the description

approved this merge request

@kienle The solution in here though fixing the bug but checking size of folder after detecting data_type. Detecting data_type might take a long time, so it delay the result of checking size of folder.

Before my vacation, you said you are going to review the whole process of this. Do you still want to do that?

Let me get back to you on this. I took a look at this around the start of your vacation, and I don't remember much of what I did. I'll have to look through my notes.

My note said that check_folders_size() can be rewritten to not need the requested waveform channels. This would allow it to be called before the data type is detected. An optimization you did would be removed, though, so the performance might suffer. I haven't checked to see if the slowdown is noticeable, however. I'll do that now.

I just tested and it looked like currently, the time spent on checking the size of a folder isn't that long. This can be merged I think.

The reason I want you to look at that not because time of checking folder size, but the time for detecting data_type might take long that delay the process of checking size so user have to wait for long before they know if the size is big or not.

However, we can merge this for now and may look back to revise this later.

My thought about this is that we can rewrite check_folders_size() to not use the waveform channels input from the user. That way, we can move that function before detecting the data type. The performance decrease is not going to be significant because check_folders_size already runs pretty quickly, so I think this is the best course of action.

I will look into it next week.

added 11 commits

• c1c281eb...b354c3d8 - 10 commits from branch develop
• 1e351acb - Merge branch 'develop' into i284_detect_no_data_stream_selected

Compare with previous version

enabled an automatic merge when the pipeline for 1e351acb succeeds

mentioned in commit f0c7ffe8

merged