Fix saving channel preferences overwrite default row status
1 unresolved thread
ALTER TABLE ChannelPrefer RENAME COLUMN "DEFAULT" to "isDefault";
Closes #280 (closed)
Also update a default row check to not rely on a hard-coded value.
Merge request reports
Activity
Filter activity
added Release2024.3.1.0 label
requested review from @ldam
assigned to @kienle
- Resolved by Lan Dam
749 759 QtWidgets.QMessageBox.information(self, "Missing info", msg) 750 760 return 751 761 sql = (f"INSERT INTO ChannelPrefer (name, preferredSOHs, dataType, " 752 f"current) VALUES " 753 f"('{name}', '{preferred_sohs}', '{data_type}', {current})") 762 f"current, isDefault) VALUES " 763 f"('{name}', '{preferred_sohs}', '{data_type}', {current}, " 764 f"{is_default_row})") 765 print(sql) changed milestone to %2024.3.1.0
added 14 commits
-
09329110...af696b27 - 10 commits from branch
develop
- b4432f80 - Change column name to avoid keyword
- 1c56ce83 - Fix default status being removed from row on save
- e0357896 - Make default row check more robust
- 67b630af - Update database
Toggle commit list-
09329110...af696b27 - 10 commits from branch
reset approvals from @ldam by pushing to the branch
mentioned in commit 76fbc636