Skip to content
Snippets Groups Projects

Fix saving channel preferences overwrite default row status

Merged Kien Le requested to merge bug-#280-saving_overwrite_channel_preferences_default_rows into develop
1 unresolved thread

ALTER TABLE ChannelPrefer RENAME COLUMN "DEFAULT" to "isDefault";

Closes #280 (closed)

Also update a default row check to not rely on a hard-coded value.

Merge request reports

Pipeline #4098 passed

Pipeline passed for 67b630af on bug-#280-saving_overwrite_channel_preferences_default_rows

Merged by Kien LeKien Le 9 months ago (Jun 27, 2024 9:30pm UTC)

Loading

Pipeline #4099 passed

Pipeline passed for 76fbc636 on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Lan Dam approved this merge request

    approved this merge request

  • Lan Dam
    Lan Dam @ldam started a thread on the diff
  • 749 759 QtWidgets.QMessageBox.information(self, "Missing info", msg)
    750 760 return
    751 761 sql = (f"INSERT INTO ChannelPrefer (name, preferredSOHs, dataType, "
    752 f"current) VALUES "
    753 f"('{name}', '{preferred_sohs}', '{data_type}', {current})")
    762 f"current, isDefault) VALUES "
    763 f"('{name}', '{preferred_sohs}', '{data_type}', {current}, "
    764 f"{is_default_row})")
    765 print(sql)
  • Lan Dam changed milestone to %2024.3.1.0

    changed milestone to %2024.3.1.0

  • Kien Le added 14 commits

    added 14 commits

    Compare with previous version

  • Kien Le reset approvals from @ldam by pushing to the branch

    reset approvals from @ldam by pushing to the branch

  • merged

  • Kien Le mentioned in commit 76fbc636

    mentioned in commit 76fbc636

  • Please register or sign in to reply
    Loading