Skip to content
Snippets Groups Projects

Solving bugs that make scroll bar disappeared after replot TPS

Merged Solving bugs that make scroll bar disappeared after replot TPS
i274_replot_caused_scroll_bar_disappear into develop
1 unresolved thread
Merged Lan Dam requested to merge i274_replot_caused_scroll_bar_disappear into develop
1 unresolved thread

closes #274 (closed)

This MR solving the problem with scroll bar disappeared when click RePlot on main control window and on TPS window as well.

Edited by Lan Dam

Merge request reports

Pipeline #3989 passed

Stage: Build Env and Test

    Pipeline passed for efffcf62 on i274_replot_caused_scroll_bar_disappear

    Approved by
    Lan Dam

    Merged by Lan DamLan Dam 9 months ago (May 15, 2024 6:42pm UTC)

    Pipeline #3991 passed

    Stage: Build Env and Test

      Pipeline passed for a145d7ed on develop

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
      sohstationviewer/view/plotting/time_power_square/time_power_squared_widget.py
      614 613 Reuse tps_data calculated in the first plotting to replot
      615 614 with new color range selected.
      616 615 """
      617 self.clear()
      616 self.clear(do_reset_size=False)
      • Kien Le
        Kien Le @kienle ·
        Developer

        Why do you not reset the size of the TPS plot when you replot?

      • Lan Dam
        Lan Dam @ldam ·
        Author Maintainer

        Because reset the size which is the task of init_size() will reset the size of the main_widget to the open view port. With the first replot, the main_widget size is resize to fit all channels. If we reset the size, we have to remember the size that fit all channels and resize the main widget with that size, which is a lot of logic. So, it's better not resetting the size.

      • Please register or sign in to reply
    • Kien Le
      Kien Le @kienle ·
      Developer

      Can you rename this MR? We want a MR's name to be what it does (e.g. "Fix something").

    • Lan Dam changed title from I274 replot caused scroll bar disappear to Solving bugs that make scroll bar disappeared after replot TPS

      changed title from I274 replot caused scroll bar disappear to Solving bugs that make scroll bar disappeared after replot TPS

    • Lan Dam changed the description

      changed the description

    • Lan Dam added 1 commit

      added 1 commit

      • 6e28f275 - add comment to explain why do_reset_size is False for replot()

      Compare with previous version

    • Lan Dam requested review from @kienle

      requested review from @kienle

    • Kien Le approved this merge request

      approved this merge request

    • Lan Dam added Release2024.3.0.1 label

      added Release2024.3.0.1 label

    • Lan Dam added 3 commits

      added 3 commits

      Compare with previous version

    • Lan Dam merged

      merged

    • Lan Dam mentioned in commit a145d7ed

      mentioned in commit a145d7ed

      • Please register or sign in to reply