Skip to content
Snippets Groups Projects

change changed status's color to blue

Merged change changed status's color to blue
i256_change_changed_color_to_blue into develop
2 unresolved threads
Merged Lan Dam requested to merge i256_change_changed_color_to_blue into develop
2 unresolved threads

closes #256 (closed)

  • Change the changed status's color to blue from red which is more of the color code for error
  • Set up in view/util/color.py the dict COLOR with meaningful color name.
  • In database dialogs, change also the background of changed widgets to light blue for case that it is changed to empty. This won't affect valueColorEdit and combo box. (Changing border won't be consider because it change styleSheet which will affect the appearance of button on widget like combo box or spin box)
Edited by Lan Dam

Merge request reports

Pipeline #3888 passed

Stage: Build Env and Test

    Pipeline passed for 699a9348 on i256_change_changed_color_to_blue

    Loading

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    sohstationviewer/view/db_config/db_config_dialog.py
    60 61 palette.setColor(QtGui.QPalette.ColorRole.Base,
    61 62 QtGui.QColor(255, 255, 255))
    62 63 if changed:
    63 # red text
    64 # blue text
    64 65 palette.setColor(QtGui.QPalette.ColorRole.Text,
    65 QtGui.QColor(255, 0, 0))
    66 QtGui.QColor(COLOR['changedStatus']))
    66 67 # The selected text in a QComboBox on Linux has ButtonText as its color
    67 68 # role (probably because the QComboBox on Linux looks like one button,
    68 69 # while the one on Mac looks like a TextEdit combined with a button).
    69 70 palette.setColor(QtGui.QPalette.ColorRole.ButtonText,
    70 QtGui.QColor(255, 0, 0))
    71 QtGui.QColor('changedStatus'))
  • Kien Le
    Kien Le @kienle ·
    Developer

    The only problem is pretty small. Fix that and this can be merged. I'll pre-approve.

  • Kien Le approved this merge request

    approved this merge request

  • Lan Dam added 16 commits

    added 16 commits

    • 0e9c14f3...cf4192a3 - 14 commits from branch develop
    • a8acf3bf - correct setting color for ButtonText
    • 699a9348 - Merge branch 'develop' into i256_change_changed_color_to_blue

    Compare with previous version

  • Lan Dam reset approvals from @kienle by pushing to the branch

    reset approvals from @kienle by pushing to the branch

  • Lan Dam enabled an automatic merge when the pipeline for 699a9348 succeeds

    enabled an automatic merge when the pipeline for 699a9348 succeeds

  • Lan Dam merged

    merged

  • Lan Dam mentioned in commit e9098d5b

    mentioned in commit e9098d5b

  • Kien Le mentioned in merge request !283 (closed)

    mentioned in merge request !283 (closed)

    • Please register or sign in to reply