Skip to content
Snippets Groups Projects

Optimize Q330 GPS calculation

Merged Optimize Q330 GPS calculation
enhancement-optimize_GPS_calculation into develop
1 unresolved thread
Merged Kien Le requested to merge enhancement-optimize_GPS_calculation into develop
1 unresolved thread

5083.sdr:

Old: 38.72

New: 0.15

Merge request reports

Pipeline #3863 passed

Stage: Build Env and Test

    Pipeline passed for 110dc34f on enhancement-optimize_GPS_calculation

    Merged by Kien LeKien Le 10 months ago (Apr 26, 2024 3:41pm UTC)

    Loading

    Pipeline #3864 passed

    Stage: Build Env and Test

      Pipeline passed for 5915a977 on develop

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
      sohstationviewer/view/plotting/gps_plot/extract_gps_data.py
      26 26 continue
      27 27 # Q330 log data is composed of a list of string, so we combine them
      28 28 # into one big string for ease of processing.
      29 log_str = functools.reduce(
      30 operator.iconcat, data_obj.log_data[station]['LOG'], ''
      31 )
      29 log_str = ''.join(data_obj.log_data[station]['LOG'])
      • Lan Dam
        Lan Dam @ldam ·
        Maintainer

        I think the connection string should be a space instead of an empty string. But maybe it's not necessary since you know about what need to be read for GPS from data more than me.

        Anyway, the result looks correct.

        Edited by Lan Dam
      • Kien Le
        Kien Le @kienle ·
        Author Developer

        The strings that I am combining start and end with a bunch of newline characters, so putting nothing between them makes it easier to separate them into a list of lines.

      • Please register or sign in to reply
    • Lan Dam
      Lan Dam @ldam ·
      Maintainer

      It really improve a lot. Thank you. Please consider my review then I can approve this.

      • Lan Dam
        Lan Dam @ldam ·
        Maintainer
        Resolved by Lan Dam

        Can you also add to tracking box a line for "Extracting GPS data...", line for "Extracting file info..." and line for "Start plotting..."?

        Edited by Lan Dam
    • Kien Le added 1 commit

      added 1 commit

      • 0892fb92 - More fine-grained progress notification

      Compare with previous version

    • Kien Le added 1 commit

      added 1 commit

      • 49e032dc - Making plotting start notification shows up

      Compare with previous version

    • Lan Dam approved this merge request

      approved this merge request

    • Kien Le added 24 commits

      added 24 commits

      Compare with previous version

      Toggle commit list
    • Kien Le reset approvals from @ldam by pushing to the branch

      reset approvals from @ldam by pushing to the branch

    • Kien Le added 6 commits

      added 6 commits

      Compare with previous version

      Toggle commit list
    • Kien Le enabled an automatic merge when the pipeline for 110dc34f succeeds

      enabled an automatic merge when the pipeline for 110dc34f succeeds

    • Kien Le merged

      merged

    • Kien Le mentioned in commit 5915a977

      mentioned in commit 5915a977

      • Please register or sign in to reply