Skip to content
Snippets Groups Projects

plot tps and waveform channels in alphabet order

Merged plot tps and waveform channels in alphabet order
i251_plot_in_order into develop
2 unresolved threads
Merged Lan Dam requested to merge i251_plot_in_order into develop
2 unresolved threads

closes #251 (closed)

  • Create axes before creating processors to make sure the order where the axes are plotted aren't messed up by the threading.
  • Channels will be ordered in alphabet order before axes are created.
Edited by Lan Dam

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
sohstationviewer/model/general_data/data_structures.MD
26 26 'chan_db_info' (dict): the plotting parameters got from database
27 27 for this channel - dict,
28 28 'ax': axes to draw the channel in PlottingWidget
29 'ax_wf' (matplotlib.axes.Axes): axes to draw the channel in WaveformWidget
29 'ax_wf' : axes to draw the channel in WaveformWidget
  • Kien Le
    Kien Le @kienle started a thread on the diff
    • sohstationviewer/view/plotting/time_power_square/time_power_squared_widget.py
    100 100 const.TPS_LEGEND_SIZE_FACTOR +
    101 101 const.TPS_SEPARATOR_SIZE_FACTOR)
    102 102
    103 def start_message_and_reset_param(self, start_msg: str):
    104 """
    105 Display start message and reset parameters for a new plotting.
    106
    107 :param start_msg: the starting message to show user that new plotting
    108 has been started.
    109 """
    • Comment on lines +103 to +109
      Kien Le
      Kien Le @kienle ·
      Developer

      I think you should replace "parameters" with "processing states". Parameter in programming has a specific meaning that is not suitable for the use here.

    • Please register or sign in to reply
  • Kien Le
    Kien Le @kienle ·
    Developer

    Looks good aside from some minor things. I'll pre-approve.

  • Lan Dam changed the description

    changed the description

  • Lan Dam added 2 commits

    added 2 commits

    Compare with previous version

  • Lan Dam added 17 commits

    added 17 commits

    Compare with previous version

  • Lan Dam merged

    merged

  • Lan Dam mentioned in commit 57291f43

    mentioned in commit 57291f43

    • Please register or sign in to reply