change tps plotting and legend to use plot instead of scatter to improve performance
All threads resolved!
Closes #234 (closed)
This MR actually doesn't improve the performance of plotting. For some cases it even slightly slow down plotting speed. However, it speed up the speed of showing the highlight box when cmd/ctrl + click on a point for information.
Ex: 6407.sdr, channel LH1's TPS, time from the start of on_pick_event() until end of on_ctrl_cmd_click():
- develop branch: 1.26s
- This branch: 0.67s
Plotting LH1's TPS
- develop branch: 3.6s
- This branch: 3.3s
Ex:Q330_5281.sdr, HHE's TPS
- develop branch: 0.975s
- This branch: 1.048s
Ex:5083.sdr
develop branch:
- LH1 TPS time: 21.69738221168518
- BH1 TPS time: 239.42422819137573
- HH1 TPS time: 409.018563747406
This branch:
- LH1 TPS time: 20.051087856292725
- BH1 TPS time: 95.44239091873169
- HH1 TPS time: 333.11667704582214
When plot all channels
develop branch:
- LH1 TPS time: 71.20173382759094
- LH2 TPS time: 75.62472915649414
- LHZ TPS time: 80.02365779876709
- BH1 TPS time: 816.4232420921326
- BHZ TPS time: 866.268630027771
- BH2 TPS time: 935.9406130313873
- HHZ TPS time: 1822.6974408626556
- HH1 TPS time: 1834.4737071990967
- HH2 TPS time: 1842.444128036499
This branch:
- LH1 TPS time: 65.75834012031555
- LHZ TPS time: 69.33358788490295
- LH2 TPS time: 73.3008508682251
- BH1 TPS time: 713.9739570617676
- BHZ TPS time: 720.5219311714172
- BH2 TPS time: 728.0735080242157
- HHZ TPS time: 1414.3021039962769
- HH1 TPS time: 1426.1622381210327
- HH2 TPS time: 1434.9592089653015
Edited by Lan Dam
Merge request reports
Activity
Filter activity
assigned to @ldam
requested review from @kienle
- Resolved by Kien Le
Can you post some time measurement so we can see how much faster this MR is compared to develop?
- Resolved by Kien Le
requested review from @kienle
added 25 commits
-
207a3b79...6d9db698 - 24 commits from branch
develop
- 02eb874b - Merge branch 'develop' into change_plotting_TPS_to_improve_performance
-
207a3b79...6d9db698 - 24 commits from branch
mentioned in commit f2cdbcc6
Please register or sign in to reply