Use new editor for valuesColor in Parameter dialog

Closes #193 (closed)

Closes #59 (closed)

Closes #239 (closed)

• Use ValueColorEdit for valuesColor in Parameter dialog

• Refactored creation of cell editors in database editor

• Fix regex used to validate valueColors

• Consolidate about plot types into one place

  This file contains the SQL statements needed to update the database

  update_value_colors.sql

requested review from @ohosseini

assigned to @kienle

This looks Okay to me. I don't know if there's a better way to do it or not. Which branch is the best one for the code review? I want to go through the code and review it.

Thank you Omid. I am not finished with this MR yet. I only wanted someone to look over the refactoring I did to to make sure that what I did is not bad OOP design. I will ask Lan to review this when I'm done. There are some changes I will be making that she needs to look at.

approved this merge request

added 19 commits

• 2787848d...c1ef93dc - 9 earlier commits
• aa940f91 - Change how channels with valueColors are found
• d19a07e7 - Change how a row is gotten from the Params editor
• d35df968 - Let user edit value colors in ValueColorEdit
• 14c18e16 - Add valueColors editor for dotForTime plots
• d135ba1e - Change file name to be more in line with purpose
• bc712824 - Use ROOT_PATH constant instead of dynamic compute
• 0378b216 - Change variable name to be more descriptive
• 2639a680 - Add unit test cases
• ea587562 - flake8
• cfdb0359 - Update all valueColors to new format

Compare with previous version

requested review from @ldam

changed the description

changed the description

Please update Plotting's functions to work with new format for valueColors.

added 71 commits

• cfdb0359...84f20438 - 24 commits from branch master
• 84f20438...95445d9d - 37 earlier commits
• 2cebfdcd - Changes default value for parameter
• f45064ed - Add documentation
• 73bc7e53 - Fix parsing value colors for triColorLines plots
• 35794f02 - Fix parsing value colors for upDownDots plots
• cb9a945d - Fix parsing value colors for dotForTime plots
• 937841f3 - Fix parsing value colors for linesDots plots
• 78c39382 - Fix parsing value colors for multiColorDots plots
• 809946d6 - Stop converting value colors from old format
• a8551f8f - Fix color format
• 69dc1c60 - Implement save for new valueColors editor

Compare with previous version

changed target branch from master to develop

requested review from @ldam

added 5 commits

• 2f9afb7f - Fix parsing value colors for multiColorDots plots
• e0904dcf - Stop converting value colors from old format
• e77a258f - Fix color format
• 360f40b9 - Implement save for new valueColors editor
• d0951ec9 - flake8

Compare with previous version