Skip to content
Snippets Groups Projects

Fix channel prefer dialog not save

Merged Lan Dam requested to merge i222_channel_prefer_dialog_not_save into develop

Closes #222 (closed)

  • The reason that new channel preferences isn't saved because its editing isn't finished if click on Save right after editing. So setFocus is called on save button to finish it.
  • Also more condition is checked and correct on create sqls
  • To be more descriptive variable idx has been changed to preferred_sohs and database table ChannelPrefer's IDs has been changed to preferredSOHs.
Edited by Lan Dam

Merge request reports

Pipeline #3702 passed

Pipeline passed for 70512eea on i222_channel_prefer_dialog_not_save

Merged by Lan DamLan Dam 11 months ago (Apr 4, 2024 8:11pm UTC)

Loading

Pipeline #3703 passed

Pipeline passed for 919d47a5 on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Kien Le
  • Kien Le
  • Lan Dam added 1 commit

    added 1 commit

    • 49a31af9 - exclude ‘Default’ from avail_data_types because it only has meaning for...

    Compare with previous version

  • Lan Dam requested review from @kienle

    requested review from @kienle

  • Lan Dam added 1 commit

    added 1 commit

    Compare with previous version

  • Lan Dam requested review from @kienle

    requested review from @kienle

  • Kien Le resolved all threads

    resolved all threads

    • Resolved by Kien Le

      If there is a problem when saving the channel preferences, no error message is shown in the program. Instead, an unrelated exception is raised.

  • Lan Dam changed target branch from master to develop

    changed target branch from master to develop

  • Lan Dam added 1 commit

    added 1 commit

    • 85ee1ba7 - modify channel_prefer_dialog to print error message in the dialog's tracking...

    Compare with previous version

  • Kien Le resolved all threads

    resolved all threads

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading