Skip to content
Snippets Groups Projects

I173 print help doc in pdf

Merged Lan Dam requested to merge i173_print_help_doc_in_pdf into develop
All threads resolved!

closes #173 (closed)

Note: the images in help document must be less than 11in/1584px in width to fit in the saved pdf document.

Merge request reports

Pipeline #3630 passed

Pipeline passed for 36b1515f on i173_print_help_doc_in_pdf

Approved by

Merged by Lan DamLan Dam 11 months ago (Mar 21, 2024 5:32pm UTC)

Pipeline #3632 passed

Pipeline passed for 1a3606eb on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Developer

    Even if I click cancel, a message saying the document was saved still pops up.

  • Developer

    It might be good to have a default name for the saved file.

  • Lan Dam added 3 commits

    added 3 commits

    • a45cd2f0 - give warning when selected file have images of which width is greater than limit
    • 387ef855 - fix bug not cancel saving pdf when 'Cancel' is clicked
    • f5df69c7 - set default name for saved pdf file

    Compare with previous version

  • Lan Dam requested review from @kienle

    requested review from @kienle

  • Kien Le changed target branch from master to develop

    changed target branch from master to develop

  • Kien Le
  • Kien Le
  • Lan Dam added 2 commits

    added 2 commits

    • a5d89c3c - add checking image width to fit help document in saved pdf file
    • e43e16b5 - remove checking document images' width because that check has been moved to...

    Compare with previous version

  • Lan Dam added 1 commit

    added 1 commit

    Compare with previous version

  • Lan Dam requested review from @kienle

    requested review from @kienle

  • Kien Le resolved all threads

    resolved all threads

  • Kien Le approved this merge request

    approved this merge request

  • Lan Dam added 31 commits

    added 31 commits

    Compare with previous version

  • Lan Dam mentioned in commit 1a3606eb

    mentioned in commit 1a3606eb

  • merged

  • Please register or sign in to reply
    Loading