Resolve "remove tmp_dir_obj because not use memmap anymore"
All threads resolved!
All threads resolved!
Closes #135 (closed)
Merge request reports
Activity
Filter activity
added PriorityLow Type: Cleanup labels
assigned to @dkuehn
I took screenshots of the sample test data before and after removing references to tmp_dir_obj and tmp_dir. It doesn't look like any changes occurred.
Pegasus-sample
Master:
Without temp_dir_obj and tmp_dir:
RT130-gap
Master:
Without temp_dir_obj and tmp_dir:
Q330-sample
Master:
Without temp_dir_obj and tmp_dir:
Q330-unimplemented-ascii-block
Master:
Without temp_dir_obj and tmp_dir:
Centaur-sample
Master:
Without temp_dir_obj and tmp_dir:
Non-data-file
Master:
Without temp_dir_obj and tmp_dir:
RT130-sample
Master:
Without temp_dir_obj and tmp_dir:
Q330-multiplex
Master:
Without temp_dir_obj and tmp_dir:
@kienle Can you have a quick review at this MR please?
Looks good to me. Please rebase or merge master to this branch before merging the MR.
Edited by Kien Leadded 26 commits
-
16c52a11...1012ac3f - 22 commits from branch
master
- 5b7d4cfd - Remove every reference to tmp_dir_obj and tmp_dir
- 69912545 - Remove every reference to tmp_dir_obj and tmp_dir
- 2f0fe922 - Remove unused imports
- 8615d9e0 - revert soh.db
Toggle commit list-
16c52a11...1012ac3f - 22 commits from branch
mentioned in commit be63795b
Please register or sign in to reply