Resolve "remove tmp_dir_obj because not use memmap anymore"

Closes #135 (closed)

added PriorityLow Type: Cleanup labels

requested review from @kienle and @ldam

assigned to @dkuehn

added 2 commits

• b0ce8ba7 - Remove every reference to tmp_dir_obj and tmp_dir
• 2698565e - Remove every reference to tmp_dir_obj and tmp_dir

Compare with previous version

I took screenshots of the sample test data before and after removing references to tmp_dir_obj and tmp_dir. It doesn't look like any changes occurred.

Pegasus-sample

Master:

Without temp_dir_obj and tmp_dir:

RT130-gap

Master:

Without temp_dir_obj and tmp_dir:

Q330-sample

Master:

Without temp_dir_obj and tmp_dir:

Q330-unimplemented-ascii-block

Master:

Without temp_dir_obj and tmp_dir:

Centaur-sample

Master:

Without temp_dir_obj and tmp_dir:

Non-data-file

Master:

Without temp_dir_obj and tmp_dir:

RT130-sample

Master:

Without temp_dir_obj and tmp_dir:

Q330-multiplex

Master:

Without temp_dir_obj and tmp_dir:

added 1 commit

• d75b42bd - Remove unused imports

Compare with previous version

marked this merge request as ready

There are 3 files listed in changes in which, I don't think you have intentionally changed soh.db. Please add only the files you have modified.

If you have any changes in database (soh.db), you need to state the sql in the description.

added 1 commit

• 16c52a11 - revert soh.db

Compare with previous version

resolved all threads

@kienle Can you have a quick review at this MR please?

Looks good to me. Please rebase or merge master to this branch before merging the MR.

approved this merge request

added 26 commits

• 16c52a11...1012ac3f - 22 commits from branch master
• 5b7d4cfd - Remove every reference to tmp_dir_obj and tmp_dir
• 69912545 - Remove every reference to tmp_dir_obj and tmp_dir
• 2f0fe922 - Remove unused imports
• 8615d9e0 - revert soh.db

Compare with previous version

merged

mentioned in commit be63795b