Fix bug not reset is_plotting_tps, not stop when plotting tps, remove tabs incorrectly
closes #176 (closed)
Merge request reports
Activity
assigned to @ldam
requested review from @kienle
If you click stop after TPS plot is finished with no waveform data, the program breaks. I suspect this happens because TPS processing finishes before the code has to chance to connect the stop TPS widgets' signals to the method that would update the flags in the main window. One fix I can think of is to create the widgets and connect their signals before starting the processing.
I don't really understand the case you mentioned above. But when I tried to run for the case with no waveform data then try to run another data set, the program broke which the same reason as you stated above.
So I added a fix to go ahead and reset the flag is_plotting_tps with some comment to explain the case. It's a little bit dirty but it works.
Can you try the case you mentioned to see if it works now?
Edited by Lan Dam
added 5 commits
-
913d6eff...b7b5f902 - 4 commits from branch
master - cba1e873 - Merge branch 'master' into i176_fix_tps_bug
-
913d6eff...b7b5f902 - 4 commits from branch
added 1 commit
- 3ba4dbcc - handle case when there're no channels for tps to plot, go ahead and reset is_plotting_tps
mentioned in commit c2c8c624
