Skip to content
Snippets Groups Projects

Fix RT130 plot failing

Merged Kien Le requested to merge bug-#70-RT130_plot_failing into master

Fix RT130 plot failing due to problem with plotting linked channels.

Closes #70 (closed).

Merge request reports

Pipeline #2494 passed

Pipeline passed for cea36a78 on bug-#70-RT130_plot_failing

Merged by Kien LeKien Le 1 year ago (Apr 24, 2023 7:57pm UTC)

Loading

Pipeline #2495 passed

Pipeline passed for 3025bd9e on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Kien Le requested review from @ldam

    requested review from @ldam

  • Maintainer

    @kienle Please give me one data set with this problem to test

  • Author Developer

    You can use 2011028.9AFA, 2013326.9E4A, 2016174.9AC4, or 2017149.92EB for testing.

  • Maintainer

    @kienle I tested with 2011028.9AFA. It plots successfully. But when I zoom, there are some errors:

    Traceback (most recent call last):
      File "/Users/ldam/Documents/GIT/sohstationviewer/sohstationviewer/view/plotting/plotting_widget/plotting_widget.py", line 382, in <lambda>
        QTimer.singleShot(1, lambda: self.zoom_bw_markers(xdata))
      File "/Users/ldam/Documents/GIT/sohstationviewer/sohstationviewer/view/plotting/plotting_widget/plotting_widget.py", line 262, in zoom_bw_markers
        self.set_lim()
      File "/Users/ldam/Documents/GIT/sohstationviewer/sohstationviewer/view/plotting/state_of_health_widget.py", line 177, in set_lim
        super().set_lim(first_time)
      File "/Users/ldam/Documents/GIT/sohstationviewer/sohstationviewer/view/plotting/plotting_widget/plotting_widget.py", line 475, in set_lim
        self.get_zoom_data(c_data, chan_id)
      File "/Users/ldam/Documents/GIT/sohstationviewer/sohstationviewer/view/plotting/state_of_health_widget.py", line 164, in get_zoom_data
        getattr(self.plotting, plot_functions[plot_type][1])(
      File "/Users/ldam/Documents/GIT/sohstationviewer/sohstationviewer/view/plotting/plotting_widget/plotting.py", line 96, in plot_multi_color_dots
        ax.plot(points, len(points) * [0], linestyle="",
    UnboundLocalError: local variable 'points' referenced before assignment
  • Kien Le added 9 commits

    added 9 commits

    • e20413e4...edcab201 - 4 commits from branch master
    • 30664e76 - Plot channels with linked channel last
    • 43df824b - Make channels with linked channel not have main label
    • fc717670 - Fix problem with plotting waveform data
    • 5a5e80f6 - Fix problem with plotting Centaur data
    • e4c57d13 - Fix problem when zooming

    Compare with previous version

  • Kien Le removed review request for @ldam

    removed review request for @ldam

  • Kien Le requested review from @ldam

    requested review from @ldam

  • Lan Dam approved this merge request

    approved this merge request

  • Kien Le added 12 commits

    added 12 commits

    • e4c57d13...49657765 - 7 commits from branch master
    • d0117dc6 - Plot channels with linked channel last
    • 31c6bf06 - Make channels with linked channel not have main label
    • 7abb92e5 - Fix problem with plotting waveform data
    • fac2fd03 - Fix problem with plotting Centaur data
    • cea36a78 - Fix problem when zooming

    Compare with previous version

  • merged

  • Kien Le mentioned in commit 3025bd9e

    mentioned in commit 3025bd9e

Please register or sign in to reply
Loading