Pyside

Change GUI to PySide2

requested review from @maeva

assigned to @dkuehn

added 1 commit

• 2b1c5e0f - install libgl1-mesa-glx library

Compare with previous version

added 1 commit

• 280297fb - fix linting

Compare with previous version

I just finished reviewing your MR. There are a few things that need to be addressed. I will list them below. Otherwise that looks good.

This looks good to me now. I will go ahead and merge this branch to the master one.

The position of the Block Number slide button doesn't automatically get updated when updating the Jump To Block # value. See below screenshot.

The Blockette Information block needs to be reformatted. The lack of consistent indentation reduces the readability on the user-end. See the below screenshots for a comparison of how it used to be and how it is displayed now.

Same comment as above.

Some sections of the Help page needs to be reformatted to improve readability. See the below screenshots for a comparison of how it used to be and how it is displayed now.

The correct version number for this release should be 2022.2.0.0. The year remains the same since 2022 is the year this package was released under the new versioning scheme. In this case, we will update the major version number since the changes applied are not backward compatible.

The version number needs to be updated in the following files:

• setup.py
• meta.yaml
• mseedpeek.py
• init.py

For this new release, we will support python 3.8+.

The python version number(s) need(s) to be updated in the following files:

• setup.py
• meta.yaml

There are still a few linting errors (E501 - line too long) that need to be addressed as well before we can merge these commits.

added For: Software PriorityHigh StatusRevision Needed Type: Cleanup Type: Enhancement labels

added 1 commit

• 2aebe172 - Update version number and python support number

Compare with previous version

added 1 commit

• 9f113bb6 - Fix Help tab formatting

Compare with previous version

added 1 commit

• fc7f6ff0 - Fix mseedinfo formatting

Compare with previous version

added 1 commit

• b8c75c2f - Fix linting for mseedpeek

Compare with previous version

added 1 commit

• f3115a2c - fix linting for mseedinfo

Compare with previous version

The widgets displaying information about the selected mseed file have disappeared since your latest changes to the code base. See screen capture below.

Perhaps this happen when you were trying to figure out how to fix the updating issue with the sliding button.

marked this merge request as ready

resolved all threads