use has_abort flag to add/not add abort button to create_multi_buttons_dialog;...

use has_abort flag to add/not add abort button to create_multi_buttons_dialog; adjust code to use this has_abort button

sohstationviewer/model/data_loader.py

@@ -239,5 +239,5 @@ class DataLoader(QtCore.QObject):
         :type button_labels: List[str]
         """
         chosen_idx = create_multi_buttons_dialog(
-            msg, button_labels, abort_is_0=True)
+            msg, button_labels, has_abort=False)
         self.worker.button_chosen.emit(chosen_idx)

sohstationviewer/model/general_data/general_data.py

@@ -266,7 +266,7 @@ class GeneralData():
         loaded.
         """
         msg = "Please select one of the following keys:"
-        ret = create_multi_buttons_dialog(msg, self.keys, abort_is_0=False)
+        ret = create_multi_buttons_dialog(msg, self.keys, has_abort=True)
         if ret == -1:
             return False
         self.selected_key = self.keys[ret]

sohstationviewer/view/create_muti_buttons_dialog.py

@@ -4,16 +4,16 @@ from PySide2 import QtWidgets
 
 
 def create_multi_buttons_dialog(
-        msg: str, button_labels: List[str], abort_is_0) -> int:
+        msg: str, button_labels: List[str], has_abort) -> int:
     """
     Create a modal dialog with buttons. Show the dialog and send the user's
     choice to the data object being created.
 
     :param msg: the instruction shown to the user
     :param button_labels: the list of labels that are shown on the buttons
-
+    :param has_abort: flag to add Abort button or not
     :return chosen_idx: index of selected button. If abort_button is selected,
-        return 0 if abort_is_0=True or -1 otherwise.
+        return -1
     """
     msg_box = QtWidgets.QMessageBox()
     msg_box.setText(msg)
@@ -30,11 +30,14 @@ def create_multi_buttons_dialog(
         buttons.append(
             msg_box.addButton(label, QtWidgets.QMessageBox.ActionRole)
         )
-    abort_button = msg_box.addButton(QtWidgets.QMessageBox.Abort)
+    if has_abort:
+        abort_button = msg_box.addButton(QtWidgets.QMessageBox.Abort)
 
     msg_box.exec_()
-    if msg_box.clickedButton() == abort_button:
-        chosen_idx = -1
-    else:
-        chosen_idx = buttons.index(msg_box.clickedButton())
+    try:
+        if msg_box.clickedButton() == abort_button:
+            return -1
+    except UnboundLocalError:
+        pass
+    chosen_idx = buttons.index(msg_box.clickedButton())
     return chosen_idx