From 5653b4d79aef2d0940a85053963e3f593e385720 Mon Sep 17 00:00:00 2001
From: ldam <ldam@passcal.nmt.edu>
Date: Wed, 23 Aug 2023 12:46:07 -0600
Subject: [PATCH] remove set_lim() in subclass
---
.../multi_threaded_plotting_widget.py | 26 -------------------
.../view/plotting/state_of_health_widget.py | 3 ---
.../view/plotting/waveform_dialog.py | 3 ---
3 files changed, 32 deletions(-)
diff --git a/sohstationviewer/view/plotting/plotting_widget/multi_threaded_plotting_widget.py b/sohstationviewer/view/plotting/plotting_widget/multi_threaded_plotting_widget.py
index 7a6caf5ff..35d207e62 100644
--- a/sohstationviewer/view/plotting/plotting_widget/multi_threaded_plotting_widget.py
+++ b/sohstationviewer/view/plotting/plotting_widget/multi_threaded_plotting_widget.py
@@ -310,29 +310,3 @@ class MultiThreadedPlottingWidget(PlottingWidget):
f'{self.name} plot stopped', 'info')
self.is_working = False
self.stopped.emit()
-
- def set_lim(self, first_time=False, is_waveform=False):
- """
- The set_lim method of the base class PlottingWidget was not designed
- with multi-threading in mind, so it made some assumption that is
- difficult to satisfy in a multi-threaded design. While these
- assumptions do not affect the initial plotting of the data, they make
- designing a system for zooming more difficult.
-
- Rather than trying to comply with the design of PlottingWidget.set_lim,
- we decide to work around. This set_lim method still keeps the
- functionality of processing the data based on the zoom range. However,
- it delegates setting the new limit of the x and y axes to
- PlottingWidget.set_lim.
-
- :param first_time: flag that indicate whether set_lim is called the
- fist time for a data set.
- """
- self.data_processors = []
- if not self.is_working:
- self.is_working = True
- start_msg = 'Zooming in...'
- display_tracking_info(self.tracking_box, start_msg, 'info')
- self.create_plotting_channel_processors(self.plotting_data1)
- self.create_plotting_channel_processors(self.plotting_data2)
- self.process_channel()
diff --git a/sohstationviewer/view/plotting/state_of_health_widget.py b/sohstationviewer/view/plotting/state_of_health_widget.py
index acb00711d..847a7024e 100644
--- a/sohstationviewer/view/plotting/state_of_health_widget.py
+++ b/sohstationviewer/view/plotting/state_of_health_widget.py
@@ -79,6 +79,3 @@ class SOHWidget(MultiThreadedPlottingWidget):
artist.remove()
getattr(self.plotting, plot_functions[plot_type][1])(
c_data, chan_db_info, chan_id, c_data['ax'], linked_ax)
-
- def set_lim(self, first_time=False):
- super().set_lim(first_time, is_waveform=False)
diff --git a/sohstationviewer/view/plotting/waveform_dialog.py b/sohstationviewer/view/plotting/waveform_dialog.py
index ffcc0eac5..e32537fb3 100755
--- a/sohstationviewer/view/plotting/waveform_dialog.py
+++ b/sohstationviewer/view/plotting/waveform_dialog.py
@@ -65,9 +65,6 @@ class WaveformWidget(MultiThreadedPlottingWidget):
getattr(self.plotting, plot_functions[plot_type][1])(
c_data, chan_db_info, chan_id, c_data['ax_wf'], None)
- def set_lim(self, first_time=False):
- super().set_lim(first_time, is_waveform=True)
-
class WaveformDialog(QtWidgets.QWidget):
def __init__(self, parent):
--
GitLab